[PM-12352] Incorporate the minimum amount of changes to ensure OverlayBackground instantiates on init of the extension

[cagonzalezcs]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12352

📔 Objective

A number of issues are being reported in relation to autofill behavior for the extension. These include the following:

• Potential Chrome/ChomeOS Bug  #11080
• Autofill and context menu stopped working. #10814
• Autofill has stopped working across all sites in Firefox on Linux #10815

Replicate of the behavior described in these tickets is difficult to do, but more than likely the core issue revolves around how we are handling initialization of the OverlayBackground and TabsBackground classes within the MainBackground class of the extension.

These two problematic classes are being instantiated behind a feature flag, which depends on config data from the server. The behavior described by end users points to some issue with triggering the behavior in those classes.

To resolve this, we need to pull the instantiation of those classes into the constructor of the MainBackground class, as was originally done. This will remove the potential of initializing the LegacyOverlayBackground entirely, but incorporating this fix represents the most logical course of action to resolve these issues that users are experiencing.

We will be petitioning the community to verify that this fixes their issues through a side-loaded artifact. If this indicates a resolution for the majority of users, we will begin discussions on incorporating these set of changes as a hotfix for the extension.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.19%. Comparing base (80d0f7e) to head (f002377).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
apps/browser/src/background/main.background.ts	0.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11134   +/-   ##
=======================================
  Coverage   33.19%   33.19%           
=======================================
  Files        2780     2780           
  Lines       86410    86393   -17     
  Branches    16468    16462    -6     
=======================================
  Hits        28680    28680           
+ Misses      55445    55429   -16     
+ Partials     2285     2284    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – c069d44e-3682-4c57-ba8b-c134f16cceea

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health.component.html: 45	Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health.component.ts: 54	Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health.component.ts: 52	Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health.component.ts: 48	Attack Vector
	Client_Privacy_Violation	/apps/browser/src/background/main.background.ts: 641	Attack Vector
	Client_Privacy_Violation	/apps/browser/src/background/main.background.ts: 976	Attack Vector
	Client_Privacy_Violation	/apps/browser/src/background/main.background.ts: 962	Attack Vector
	Client_Privacy_Violation	/apps/browser/src/background/main.background.ts: 619	Attack Vector
	Client_Privacy_Violation	/apps/browser/src/background/main.background.ts: 694	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health.component.html: 50
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health.component.html: 45
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health.component.html: 40
	Client_Privacy_Violation	/apps/web/src/app/tools/access-intelligence/password-health.component.html: 45

[cagonzalezcs]

Converting this to a draft to ensure we don't accidentally merge the work in.