Add concrete FlightRecorderDiskSource

[david-livefront]

🎟️ Tracking

PM-29912

📔 Objective

This PR Moves as much logic as possible into a central location and exposes it via the app-specific SettingsRepositorys.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[david-livefront]

I am a little torn with this.

On one hand, this centralizes a decent bit of logic but it is a bit cumbersome in the these places.

[SaintPatrck]

I agree with Claude. The trade-off here is worth it. 🚀

[claude]

Claude finished @david-livefront's task in 4m 2s —— View job

---

Code Review Summary

Status: ✅ Approved with minor suggestion

This PR successfully extracts flight recorder disk operations into a dedicated FlightRecorderDiskSource implementation, improving code organization and reusability across both app and authenticator modules.

Overview

Change Type: Refactoring
Risk Level: Low
Test Coverage: Comprehensive

Key Changes

1. New FlightRecorderDiskSource interface and implementation - Centralizes flight recorder persistence logic in the data module
2. Delegation pattern - Both SettingsDiskSourceImpl classes now delegate to FlightRecorderDiskSource for flight recorder operations
3. Dependency injection updates - Proper DI wiring in both app and authenticator modules, including transitive dependencies (BuildInfoManager, DownloadService)
4. Test infrastructure - New FlightRecorderDiskSourceTest and FakeFlightRecorderDiskSource for proper test coverage
5. Removed factory method - FlightRecorderManager.create() replaced with direct DI construction

Architecture Assessment

✅ Separation of concerns - Flight recorder logic properly isolated
✅ Delegation pattern - Correctly applied using Kotlin's by keyword
✅ Module boundaries - Clean dependency flow: app/authenticator → data
✅ DI setup - All dependencies properly wired through Hilt
✅ Test coverage - Comprehensive unit tests maintained

Findings

🎨 Suggested (1)

• Typo in test name - isFLightRecorderEnabled should be isFlightRecorderEnabled (uppercase L)

Review Complete

This is a clean refactoring that improves maintainability without introducing functional changes. The delegation pattern is well-applied, dependencies are correctly wired, and test coverage is maintained. The single finding is a minor typo that doesn't affect functionality.

---

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

[github-actions]

Checkmarx One – Scan Summary & Details – 536e57cf-f355-4ac2-923a-22e34d45fe3f

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.52%. Comparing base (5245a7a) to head (7a17b9f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6281      +/-   ##
==========================================
+ Coverage   85.45%   85.52%   +0.06%     
==========================================
  Files         776      763      -13     
  Lines       54949    54621     -328     
  Branches     7854     7852       -2     
==========================================
- Hits        46957    46712     -245     
+ Misses       5264     5181      -83     
  Partials     2728     2728              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[david-livefront]

Thanks @SaintPatrck