Skip to content

Conversation

@SaintPatrck
Copy link
Contributor

🎟️ Tracking

PM-21391

📔 Objective

This PR consolidates credential provider configuration by removing the debug-specific provider.xml and adding password credential support to the main provider configuration.

Previously, the debug build variant had a separate credential provider configuration that declared support for both TYPE_PASSWORD_CREDENTIAL and TYPE_PUBLIC_KEY_CREDENTIAL. This PR removes that debug-specific file and adds the TYPE_PASSWORD_CREDENTIAL capability to the main provider.xml, ensuring consistent credential provider capabilities across all build variants.

Changes:

  • Removed app/src/debug/res/xml/provider.xml
  • Added TYPE_PASSWORD_CREDENTIAL capability to app/src/main/res/xml/provider.xml

This enables the Credential Manager to register for password credential creation requests in all build configurations, not just debug builds.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Removes the debug-specific credential provider XML as it is no longer needed. The main provider configuration in app/src/main/res/xml/provider.xml will be used for all build variants.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
Copy link
Contributor

claude bot commented Nov 20, 2025

Claude finished @SaintPatrck's task —— View job


Code Review Complete

Overall Assessment: APPROVE

This PR correctly consolidates credential provider configuration by removing the debug-specific override and enabling password credential support across all build variants. The implementation is already present in CredentialProviderProcessorImpl.kt (via PR #5579), so this change simply ensures the OS registers Bitwarden for password credential requests in all builds.

Review Summary

Clean consolidation - The debug provider.xml was a temporary configuration to test password credential functionality during development. With the implementation now complete, this PR properly promotes that capability to production by:

  • Removing app/src/debug/res/xml/provider.xml
  • Adding TYPE_PASSWORD_CREDENTIAL to app/src/main/res/xml/provider.xml:4

Verification:

  • Password credential implementation confirmed in CredentialProviderProcessorImpl.kt:195-241
  • Manifest correctly references the provider configuration at AndroidManifest.xml:240-241
  • Implementation includes proper account handling, biometric prompts, and pending intent management

No issues found - The change is minimal, correct, and follows Android credential provider patterns.


@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.22%. Comparing base (7918abd) to head (39ed985).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6182   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         724      724           
  Lines       53005    53005           
  Branches     7705     7705           
=======================================
  Hits        45173    45173           
  Misses       5143     5143           
  Partials     2689     2689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa57a5caa-82b1-4642-8b60-e95c7d56e684

Great job! No new security vulnerabilities introduced in this pull request

@SaintPatrck SaintPatrck added this pull request to the merge queue Nov 20, 2025
Merged via the queue into main with commit 167a46a Nov 20, 2025
15 checks passed
@SaintPatrck SaintPatrck deleted the credman/register-for-password-credentials branch November 20, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants