PM-28492: Replace Authenticator Toasts with Snackbars #6180

david-livefront · 2025-11-19T20:52:31Z

🎟️ Tracking

PM-28492

📔 Objective

This PR replaces all the toasts in the Authenticator app with Snackbars.

📸 Screenshots

Screen_recording_20251119_145313.mp4

claude · 2025-11-19T20:53:35Z

Claude finished @david-livefront's task —— View job

Final Review Assessment

Overall Assessment: APPROVE

This PR successfully migrates the Authenticator app from Android Toast to Compose Snackbar pattern, following the established relay pattern from the Password Manager app. The implementation is clean and well-tested.

Remaining Recommendations:

Finding 2 (💭): SettingsViewModel subscribes to IMPORT_SUCCESS relay - verify this is intentional behavior for showing import success when returning to Settings
Finding 4 (📝): Add KDoc to SnackbarRelay enum documenting each relay's purpose and producer/consumer screens (SnackbarRelay.kt:11)
Finding 5 (📝): Add KDoc to provideSnackbarRelayManager function (PlatformUiManagerModule.kt:23)

Note: Finding 3 was withdrawn after author clarification - ItemSearchScreen correctly only subscribes to ITEM_SAVED since it doesn't navigate to add screens.

claude · 2025-11-19T20:56:16Z

...rc/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsViewModel.kt

            .onEach(::sendAction)
            .launchIn(viewModelScope)
+        snackbarRelayManager
+            .getSnackbarDataFlow(SnackbarRelay.IMPORT_SUCCESS)


💭 Finding 2: SettingsViewModel subscribes to IMPORT_SUCCESS but doesn't navigate to ImportingScreen

Details

The SettingsViewModel subscribes to SnackbarRelay.IMPORT_SUCCESS to show snackbars (lines 94-98), but the Settings screen doesn't navigate to the Importing screen where imports happen.

The ImportingViewModel sends this relay event when an import succeeds (ImportingViewModel.kt:116), then immediately navigates back. The Settings screen would show this snackbar, but only if the user happens to be on the Settings screen when returning from Import.

This pattern works but seems unusual. Consider whether:

This is intentional (showing import success when returning to Settings)

The snackbar should only be shown on the screen where import was initiated (ItemListing)

Documentation explaining this relay pattern would be helpful

For reference, the Password Manager app has similar patterns in VaultAddEditScreen subscribing to attachment upload relays.

claude · 2025-11-19T20:56:30Z

...in/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/search/ItemSearchViewModel.kt


    init {
+        snackbarRelayManager
+            .getSnackbarDataFlow(relay = SnackbarRelay.ITEM_SAVED)


💭 Finding 3: Missing snackbar relay subscription for ITEM_ADDED

Details

The ItemSearchViewModel subscribes to SnackbarRelay.ITEM_SAVED but not to SnackbarRelay.ITEM_ADDED. Since items can be added from other screens (ManualCodeEntry, QR scan), the search screen should also display those snackbars when they navigate back.

Compare with ItemListingViewModel.kt:98-102 which subscribes to both:

snackbarRelayManager .getSnackbarDataFlow(SnackbarRelay.ITEM_SAVED, SnackbarRelay.ITEM_ADDED) .map(ItemListingEvent::ShowSnackbar) .onEach(::sendEvent) .launchIn(viewModelScope)

Consider whether search should also subscribe to ITEM_ADDED, or if this is intentional behavior.

@claude You cannot add an item from the ItemSearchScreen, so there is no benefit to subscribing to that data.

Claude finished @david-livefront's task —— View job

Response to Clarification

Thank you for the clarification! You're absolutely right - since the ItemSearchScreen doesn't have functionality to navigate to screens where items can be added (like ManualCodeEntryScreen or QR scan), there's no scenario where a user would return to the search screen after adding an item. Therefore, subscribing to SnackbarRelay.ITEM_ADDED would indeed provide no benefit.

The current implementation is correct:

ItemSearchViewModel only subscribes to ITEM_SAVED because users can navigate from search → edit item → save → return to search

ItemListingViewModel subscribes to both ITEM_SAVED and ITEM_ADDED because users can navigate from listing → add/edit screens → return to listing

Finding 3 is withdrawn - the implementation is correct as-is.

claude · 2025-11-19T20:56:32Z

authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/model/SnackbarRelay.kt

+ * between producers and consumers of the data.
+ */
+@Serializable
+enum class SnackbarRelay {


📝 Finding 4: Consider adding KDoc to SnackbarRelay enum

Details

Per docs/STYLE_AND_BEST_PRACTICES.md:272-273, all public classes should include KDoc documentation. The SnackbarRelay enum is public and would benefit from documentation explaining:

The purpose of each relay constant

Which screens produce/consume each relay

Example usage pattern

Suggested documentation:

/** * Models a relay key to be mapped to an instance of [BitwardenSnackbarData] being sent * between producers and consumers of the data. */ @Serializable enum class SnackbarRelay { /** * Relays success message when import completes. * Producer: ImportingViewModel * Consumer: SettingsViewModel */ IMPORT_SUCCESS, /** * Relays success message when a new item is added. * Producer: ManualCodeEntryViewModel, ItemListingViewModel (QR scan) * Consumer: ItemListingViewModel */ ITEM_ADDED, /** * Relays success message when an existing item is saved. * Producer: EditItemViewModel * Consumer: ItemListingViewModel, ItemSearchViewModel */ ITEM_SAVED, }

claude · 2025-11-19T20:56:44Z

...rc/main/kotlin/com/bitwarden/authenticator/ui/platform/manager/di/PlatformUiManagerModule.kt

+    @Singleton
+    fun provideSnackbarRelayManager(
+        dispatcherManager: DispatcherManager,
+    ): SnackbarRelayManager<SnackbarRelay> = SnackbarRelayManagerImpl(


📝 Finding 5: Missing KDoc for provideSnackbarRelayManager function

Details

Per docs/STYLE_AND_BEST_PRACTICES.md:347-380, public functions should include KDoc documentation. This provider function should document its purpose and parameters.

Suggested documentation:

/** * Provides a singleton [SnackbarRelayManager] for the Authenticator app to relay * snackbar messages between ViewModels and screens. */ @Provides @Singleton fun provideSnackbarRelayManager( dispatcherManager: DispatcherManager, ): SnackbarRelayManager<SnackbarRelay> = SnackbarRelayManagerImpl( dispatcherManager = dispatcherManager, )

claude · 2025-11-19T20:56:46Z

...lin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingViewModel.kt

            .launchIn(viewModelScope)
+
+        snackbarRelayManager
+            .getSnackbarDataFlow(SnackbarRelay.ITEM_SAVED, SnackbarRelay.ITEM_ADDED)


👍 Exemplary implementation: Correct usage of SnackbarRelayManager pattern

This demonstrates proper usage of the relay pattern:

Subscribes to multiple relay keys in a single flow

Maps to event with BackgroundEvent marker

Uses onEach(::sendEvent) for clean event emission

Properly scoped with launchIn(viewModelScope)

This pattern is consistent with the Password Manager app's implementation.

claude · 2025-11-19T20:56:56Z

...in/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/edititem/EditItemViewModel.kt


            CreateItemResult.Success -> {
-                sendEvent(EditItemEvent.ShowToast(BitwardenString.item_saved.asText()))
+                snackbarRelayManager.sendSnackbarData(


👍 Correct pattern: Using sendSnackbarData before navigation

The pattern of sending snackbar data via relay manager before emitting NavigateBack event (lines 240-244) is correct. This ensures the destination screen can receive and display the snackbar upon arrival.

claude · 2025-11-19T20:56:57Z

...kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt

            is ItemListingEvent.NavigateToManualAddItem -> onNavigateToManualKeyEntry()
-            is ItemListingEvent.ShowToast -> {
-                Toast.makeText(context, event.message(resources), Toast.LENGTH_LONG).show()
+            is ItemListingEvent.ShowSnackbar -> {


👍 Good refactoring: Removed Toast imports and Android framework dependencies

The removal of android.widget.Toast, LocalContext, and related Android framework dependencies from the Screen composables aligns with best practices for keeping UI layer testable and framework-agnostic. Snackbars are now properly integrated with Compose's state management.

github-actions · 2025-11-19T20:58:15Z

Checkmarx One – Scan Summary & Details – bcb8adbf-a458-465e-9d51-77a4d3ddf885

Great job! No new security vulnerabilities introduced in this pull request

codecov · 2025-11-19T21:50:11Z

Codecov Report

❌ Patch coverage is 58.18182% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.26%. Comparing base (839e9e8) to head (8ed4c8a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
.../ui/platform/feature/settings/SettingsViewModel.kt	43.75%	9 Missing ⚠️
...m/feature/settings/importing/ImportingViewModel.kt	0.00%	5 Missing ⚠️
...i/platform/feature/settings/export/ExportScreen.kt	0.00%	4 Missing ⚠️
...icator/feature/itemlisting/ItemListingViewModel.kt	71.42%	2 Missing ⚠️
...latform/feature/settings/export/ExportViewModel.kt	0.00%	2 Missing ⚠️
...tor/ui/platform/feature/settings/SettingsScreen.kt	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6180      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.01%     
==========================================
  Files         724      724              
  Lines       52901    52907       +6     
  Branches     7687     7681       -6     
==========================================
+ Hits        45094    45109      +15     
+ Misses       5126     5120       -6     
+ Partials     2681     2678       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

david-livefront · 2025-11-19T22:04:24Z

Thanks @SaintPatrck

david-livefront requested review from a team and brian-livefront as code owners November 19, 2025 20:52

claude bot reviewed Nov 19, 2025

View reviewed changes

PM-28492: Replace Authenticator Toasts with Snackbars

8ed4c8a

david-livefront force-pushed the PM-28492-authenticator-snackbars branch from 1c1f757 to 8ed4c8a Compare November 19, 2025 21:20

SaintPatrck approved these changes Nov 19, 2025

View reviewed changes

david-livefront added this pull request to the merge queue Nov 19, 2025

Merged via the queue into main with commit 7918abd Nov 19, 2025
15 checks passed

david-livefront deleted the PM-28492-authenticator-snackbars branch November 19, 2025 22:37

PM-28492: Replace Authenticator Toasts with Snackbars #6180

PM-28492: Replace Authenticator Toasts with Snackbars #6180

Uh oh!

Conversation

david-livefront commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎟️ Tracking

📔 Objective

📸 Screenshots

Uh oh!

claude bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Final Review Assessment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

david-livefront Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Response to Clarification

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Great job! No new security vulnerabilities introduced in this pull request

Uh oh!

codecov bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

david-livefront commented Nov 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

david-livefront commented Nov 19, 2025 •

edited

Loading

claude bot commented Nov 19, 2025 •

edited

Loading

claude bot Nov 19, 2025 •

edited

Loading

github-actions bot commented Nov 19, 2025 •

edited

Loading

codecov bot commented Nov 19, 2025 •

edited

Loading