Skip to content

Conversation

@vvolkgang
Copy link
Member

🎟️ Tracking

PM-28029

📔 Objective

Add id-token permission to the f-droid build job. Missed in #6151.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner November 13, 2025 00:13
@claude
Copy link
Contributor

claude bot commented Nov 13, 2025

Claude finished @vvolkgang's task —— View job


Code Review Complete

Overall Assessment: APPROVE

The id-token: write permission is correctly added to the publish_fdroid job, matching the existing pattern in publish_playstore job for Azure OIDC authentication.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.99%. Comparing base (7b0b93a) to head (662bff4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6163   +/-   ##
=======================================
  Coverage   84.99%   84.99%           
=======================================
  Files         723      723           
  Lines       52854    52854           
  Branches     7676     7676           
=======================================
  Hits        44925    44925           
  Misses       5246     5246           
  Partials     2683     2683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details141e69fb-858e-4c60-ba2d-9db9a21741ca

Great job! No new security vulnerabilities introduced in this pull request

@vvolkgang vvolkgang added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 0c234ee Nov 13, 2025
13 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/fix-fdroid-build branch November 13, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants