Skip to content

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR replaces the blank accountName on manually entered TOTP codes with a null.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront marked this pull request as ready for review November 11, 2025 22:01
@claude
Copy link
Contributor

claude bot commented Nov 11, 2025

Claude finished @david-livefront's task —— View job


Code Review

Overall Assessment: APPROVE

Clean refactoring that correctly replaces empty string with null for manually entered TOTP codes, with corresponding test updates.

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.48%. Comparing base (7120eef) to head (fe7b7c5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6158      +/-   ##
==========================================
- Coverage   84.99%   84.48%   -0.52%     
==========================================
  Files         723      839     +116     
  Lines       52742    55065    +2323     
  Branches     7652     7697      +45     
==========================================
+ Hits        44827    46520    +1693     
- Misses       5242     5857     +615     
- Partials     2673     2688      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsead9232d-7d15-46f0-bf75-9f0bcfd82449

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront
Copy link
Collaborator Author

Thanks @LRNcardozoWDF & @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main with commit 35b87f4 Nov 12, 2025
17 checks passed
@david-livefront david-livefront deleted the replace-blank-with-null branch November 12, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants