All tests should assert if a value is displayed

[david-livefront]

🎟️ Tracking

N/A

📔 Objective

This PR cleans up a bunch of tests that were using isDisplayed() and isNotDisplayed() instead of the assertisDisplayed() and assertIsNotDisplayed(). This change ensures the tests are properly checking if the item is in fact visible or not.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[david-livefront]

This test was checking for inaccurate text previously but without the assertion, it was still passing

[claude]

Claude finished @david-livefront's task —— View job

---

Overall Assessment: APPROVE

This PR correctly converts non-asserting display checks to proper assertions, improving test reliability by ensuring visibility checks actually fail when elements aren't in the expected state.

Key Findings

Finding 1: Test was checking incorrect text without assertions - now fixed

The TwoFactorLoginScreenTest was checking for "Authenticator App" (capital 'A') without asserting, so it passed despite the actual UI showing "Authenticator app" (lowercase 'a'). Both the assertion and text are now correct.

Finding 2: Semantic change from isNotDisplayed to assertIsDisplayed needs verification

FoldersScreenTest.kt:114 changed from checking the empty state is NOT displayed to asserting it IS displayed. Based on test context, this appears correct, but please verify as it's a behavioral change beyond just adding assertions.

Finding 3: Test removed entirely rather than fixed

VerifyPasswordScreenTest had a test for password visibility toggling that was removed rather than fixed with proper assertions. Consider whether this functionality still needs test coverage.

See inline comments for details on each finding.

---

[david-livefront]

This test was backwards, this text should be displayed when the list is empty.

[david-livefront]

Hard to tell here but this uses a quote and should have had a curly quote.

[github-actions]

Checkmarx One – Scan Summary & Details – dcc76725-dc4e-4180-8805-c13820e2ca8b

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.99%. Comparing base (7a6a493) to head (edcd086).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6153   +/-   ##
=======================================
  Coverage   84.99%   84.99%           
=======================================
  Files         723      723           
  Lines       52740    52740           
  Branches     7649     7649           
=======================================
  Hits        44824    44824           
  Misses       5243     5243           
  Partials     2673     2673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.