-
Notifications
You must be signed in to change notification settings - Fork 927
[PM-27901] Add f-droid fastlane metadata #6134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @vvolkgang's task —— View job Review Complete
Overall Assessment: APPROVE Previous findings have been resolved. Files meet F-Droid metadata requirements. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6134 +/- ##
==========================================
- Coverage 84.97% 84.95% -0.02%
==========================================
Files 723 735 +12
Lines 52746 52980 +234
Branches 7649 7651 +2
==========================================
+ Hits 44822 45011 +189
- Misses 5250 5295 +45
Partials 2674 2674 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job! No new security vulnerabilities introduced in this pull request |
| @@ -0,0 +1 @@ | |||
| Bitwarden is a login and password manager that helps keep you safe while online. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical Issue: Filename has trailing space
The filename short_description.txt has a trailing space character. This will cause issues with F-Droid's metadata parser and build process.
Required action: Rename the file to remove the trailing space:
git mv "app/src/fdroid/fastlane/metadata/android/en-US/short_description.txt " \
"app/src/fdroid/fastlane/metadata/android/en-US/short_description.txt"Character count: The description content is 79 characters (excluding newline), which properly meets F-Droid's 80-character maximum requirement.
app/src/fdroid/fastlane/metadata/android/en-US/full_description.txt
Outdated
Show resolved
Hide resolved
8b19f3a to
f43a032
Compare
app/src/fdroid/fastlane/metadata/android/en-US/full_description.txt
Outdated
Show resolved
Hide resolved
…n.txt Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Patrick Honkonen <1883101+SaintPatrck@users.noreply.github.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

🎟️ Tracking
PM-27901
📔 Objective
Add required fastlane metadata for the f-droid build to support the distribution of Password Manager in the main f-droid repo, as requested in https://gitlab.com/fdroid/fdroiddata/-/merge_requests/19550#note_2770875171. Focusing on the required text files for the time being, we can later expand it with by adding the optional content.
File Location
File location documentation: https://gitlab.com/-/snippets/1895688#locations
In this PR we're going with the third option given our monorepo, providing metadata specific to the Password Manager f-droid app build without affecting Authenticator.
Folder Structure Reference
From https://gitlab.com/-/snippets/1895688#structure:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes