Skip to content

Conversation

@SaintPatrck
Copy link
Contributor

🎟️ Tracking

N/A

📔 Objective

Refines the reviewing-changes skill to address verbosity and excessive complimentary feedback identified in recent PR
reviews. The skill was generating 800+ token summaries with multiple sections (Strengths, Recommendations, Test
Coverage Status, Architecture Compliance) and creating praise-only inline comments that cluttered PR conversations
without providing actionable feedback.

Key improvements:

  • Mandates <details> tags for all inline comments - only severity + one-line description visible, all details
    collapsed
  • Eliminates praise-only comments - explicit prohibition against creating inline comments solely for positive feedback
  • Simplifies summary format - scales with PR complexity (simple PRs = 3-5 lines, complex PRs = add brief context
    paragraph)
  • Adds thread detection - new Step 1 checks existing PR comments to prevent duplicate findings when re-reviewing
  • Consolidates examples file - reduced from ~7,570 to ~1,700 tokens (77% reduction) by removing redundant format
    guidance that duplicated SKILL.md content
  • Aligns format - resolves contradiction between SKILL.md and examples, both now use summary + inline comments
    approach
  • Updates severity prefixes - hybrid emoji + text format (⚠️ CRITICAL, 📋 IMPORTANT, 💡 SUGGESTED, ❓ QUESTION) for
    visual scanning + searchability

Impact: Reviews will be more concise, focused exclusively on actionable issues, visually cleaner in PR conversations,
and avoid spamming duplicate comments on re-reviews. Net reduction of 3,500 tokens (13%) in total skill context while
maintaining comprehensive review capability.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Addresses issues where reviews were too verbose with excessive complimentary comments and duplicate findings. Key improvements: mandate <details> tags for visual clarity, eliminate praise-only comments, simplify summary format to scale with PR complexity, add thread detection to prevent duplicates on re-reviews, and consolidate examples file (77% reduction). Format now aligns between SKILL.md and examples with consistent hybrid emoji+text severity prefixes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@SaintPatrck SaintPatrck requested a review from a team as a code owner November 5, 2025 20:35
@claude
Copy link
Contributor

claude bot commented Nov 5, 2025

Claude finished @SaintPatrck's task —— View job


Review Complete

Overall Assessment: APPROVE

This PR successfully refines the reviewing-changes skill to eliminate verbosity and praise-only feedback. The changes align perfectly with the stated objectives and deliver measurable improvements in token efficiency and output clarity.

Key Improvements Validated:

  • ✅ Mandated <details> tags for all inline comments (SKILL.md:147-161)
  • ✅ Explicit prohibition of praise-only comments (SKILL.md:137-143)
  • ✅ Simplified summary format that scales with PR complexity (SKILL.md:187-204)
  • ✅ Added thread detection as Step 1 to prevent duplicate comments (SKILL.md:13-51)
  • ✅ Consolidated examples file from ~7,570 to ~1,700 tokens (77% reduction)
  • ✅ Aligned format between SKILL.md and examples (both use summary + inline comments)
  • ✅ Updated severity prefixes to hybrid emoji + text format (SKILL.md:211-215)
  • ✅ Removed redundant sections from checklist files (infrastructure.md, ui-refinement.md)

Token Reduction Impact:

  • Examples file: 645 lines removed, 227 lines added (net -418 lines)
  • Total skill context: ~3,500 token reduction (13% decrease) as claimed
  • Format guidance consolidated, eliminating duplication between files

Pattern Consistency:
The changes maintain internal consistency across all skill files. The anti-patterns section (SKILL.md:224-243) effectively demonstrates what to avoid, reinforcing the new concise approach.


@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.96%. Comparing base (aceb96d) to head (d09e28f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6128   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files         724      724           
  Lines       52758    52758           
  Branches     7659     7659           
=======================================
  Hits        44826    44826           
  Misses       5249     5249           
  Partials     2683     2683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Logo
Checkmarx One – Scan Summary & Detailsd6c53a7a-9788-470b-b349-49dfa85f454e

Great job! No new security vulnerabilities introduced in this pull request

@SaintPatrck SaintPatrck added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit dca97e0 Nov 5, 2025
13 checks passed
@SaintPatrck SaintPatrck deleted the claude-reviewing-changes-skill-tweaks branch November 5, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants