Skip to content

Conversation

@andrebispo5
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26420
https://bitwarden.atlassian.net/browse/PM-27369
https://bitwarden.atlassian.net/browse/PM-27371
https://bitwarden.atlassian.net/browse/PM-27372
https://bitwarden.atlassian.net/browse/PM-27373

📔 Objective

This pull request primarily refactors how logging and parameters are handled during the vault unlock and PIN migration processes. The main focus is to clean up redundant logging and simplify method signatures, while ensuring that relevant debug information is still captured.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsab7306d7-3728-487f-9fe0-a0db6cf36e1f

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.78%. Comparing base (51c23ec) to head (fbc3b17).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6084   +/-   ##
=======================================
  Coverage   84.77%   84.78%           
=======================================
  Files         721      721           
  Lines       52820    52820           
  Branches     7668     7668           
=======================================
+ Hits        44779    44781    +2     
+ Misses       5355     5352    -3     
- Partials     2686     2687    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrebispo5 andrebispo5 added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit c0f8307 Oct 27, 2025
11 checks passed
@andrebispo5 andrebispo5 deleted the pm-26420/unlock-method-log branch October 27, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants