[PM-22157] independent version names in build workflows #6074
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6074 +/- ##
==========================================
+ Coverage 84.78% 84.80% +0.02%
==========================================
Files 720 720
Lines 55051 52764 -2287
Branches 7653 7653
==========================================
- Hits 46675 44747 -1928
+ Misses 5695 5336 -359
Partials 2681 2681 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Fixed Issues (2)Great job! The following issues were fixed in this Pull Request
|
.github/workflows/build.yml
Outdated
| # Start from 11000 to prevent collisions with mobile build version codes | ||
| base_version_number: 11000 | ||
| version_name: ${{ inputs.version-name }} | ||
| version_number: ${{ inputs.version-number }} |
There was a problem hiding this comment.
I think this should be inputs.version-code?
There was a problem hiding this comment.
version-code is definitely more appropriate for android, however the inputs declared in _version.yml are copied from ios and will eventually be shared across both platforms (and possibly others). I assume the terminology was chosen to be as generic as possible, but @vvolkgang can correct me if I'm wrong?
There was a problem hiding this comment.
I mean shouldn't we be passing inputs.version-code as version-number since that's the input variable defined for this job? (L14)
| version_number: ${{ inputs.version-number }} | |
| version_number: ${{ inputs.version-code }} |
There was a problem hiding this comment.
OH! 🤦 yes, good catch.
| app_codename: "bwa" | ||
| base_version_number: 0 | ||
| version_name: ${{ inputs.version-name }} | ||
| version_number: ${{ inputs.version-number }} |
There was a problem hiding this comment.
Same. This should probably be inputs.version-code?
|
Warning @mpbw2 Uploading code coverage report failed. Please check the "Upload to codecov.io" step of Process Test Reports job for more details. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-22157
📔 Objective
Introduce
_version.ymland add app-specific tag support to workflows⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes