Implement reusable Claude code review workflow #6072
Merged
+288
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theMickster
requested review from
a team,
brian-livefront and
david-livefront
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6072 +/- ##
========================================
Coverage 84.80% 84.80%
========================================
Files 737 720 -17
Lines 53128 52777 -351
Branches 7657 7655 -2
========================================
- Hits 45056 44760 -296
+ Misses 5391 5336 -55
Partials 2681 2681 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
theMickster
commented
Oct 23, 2025
This commit overhauls the `CLAUDE.md` file to provide a more comprehensive set of guidelines for AI-assisted development on the Bitwarden Android project. The updated document establishes clear directives and standards, including: * Core directives emphasizing adherence to project architecture, code style, and established patterns. * An overview of module organization and key architectural patterns like MVVM, Hilt, and UDF. * Security requirements that must be considered with every change. * A structured workflow covering pre-implementation, implementation, and post-implementation steps. * A list of anti-patterns to avoid. * Guidelines for communication, decision-making, and when to seek clarification. * A refined list of essential reference documents.
This commit introduces a new `reviewing-changes` skill to formalize the code review process for Bitwarden Android. The skill provides a structured, step-by-step guide for conducting comprehensive code reviews, covering context, compliance, documentation, and providing actionable feedback. The primary `CLAUDE.md` file has been refactored to be more concise by removing redundant horizontal rule separators. Additionally, the `review-code.md` prompt has been updated to directly invoke the new `reviewing-changes` skill, simplifying the review initiation process.
This commit updates the `.github/CODEOWNERS` file to establish ownership for Claude-related files. A new rule has been added that assigns ownership of all files and subdirectories within the `.claude/` directory to the `@bitwarden/team-ai-sme` team. This ensures that the appropriate team is automatically requested for review on any pull requests modifying these files.
withinfocus
previously approved these changes
Oct 23, 2025
This commit removes parenthetical line number references from the `reviewing-changes/SKILL.md` file. These references pointed to the `CLAUDE.md` file and were removed to improve readability and prevent them from becoming outdated as `CLAUDE.md` changes.
This commit updates the `reviewing-changes/SKILL.md` document to improve readability. Code formatting (using backticks) has been applied to file paths, file extensions, and code-specific terms such as `StateFlow`, `@HiltViewModel`, and `biometricPrompt`.
theMickster
commented
Oct 24, 2025
withinfocus
reviewed
Oct 24, 2025
SaintPatrck
reviewed
Oct 24, 2025
SaintPatrck
approved these changes
Oct 27, 2025
david-livefront
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26935
📔 Objective
Establish Claude AI-assisted code review infrastructure for the Bitwarden Android project, including automated workflows, comprehensive development guidelines, and team ownership configuration.
Infrastructure & Automation
Claude Configuration
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes