Skip to content

Conversation

@SaintPatrck
Copy link
Contributor

🎟️ Tracking

PM-26810

📔 Objective

This commit addresses an issue where the verification code input field was not cleared after a successful Two-Factor Authentication (2FA) verification during the item export process.

When handling a VerifyOtpResult.Verified action, the view model state is now updated to reset the input field to an empty string. This ensures the verification code is no longer visible in the input field after the OTP dialog is dismissed and the user proceeds.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

This commit addresses an issue where the password input field was not cleared after a successful Two-Factor Authentication (2FA) verification during the item export process.

When handling a `VerifyOtpResult.Verified` action, the view model state is now updated to reset the `input` field to an empty string. This ensures the password is no longer visible in the input field after the OTP dialog is dismissed and the user proceeds.
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc8ec011f-23d2-4ac4-94b0-0e2938232c88

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.78%. Comparing base (92cfce1) to head (fef7bf0).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6070      +/-   ##
==========================================
+ Coverage   84.23%   84.78%   +0.54%     
==========================================
  Files         829      720     -109     
  Lines       57359    55052    -2307     
  Branches     7699     7653      -46     
==========================================
- Hits        48319    46677    -1642     
+ Misses       6345     5694     -651     
+ Partials     2695     2681      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck SaintPatrck added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit bb11b17 Oct 23, 2025
9 checks passed
@SaintPatrck SaintPatrck deleted the PM-26810/clear-totp-input branch October 23, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants