[PM-26810] Remove loading dialog flicker on vault data updates #6068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
a team,
brian-livefront and
david-livefront
as code owners
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
|
|
||
| private fun handleVaultDataLoading() { | ||
| showLoadingDialog() | ||
| Timber.d("handleVaultDataLoading called") |
Collaborator
There was a problem hiding this comment.
Can we drop the log?
This commit addresses a UI flicker issue where a loading dialog would briefly appear, or remain visible, when the vault data was being updated in the background during the item export flow. The `handleVaultDataPending` function in `ReviewExportViewModel` was unnecessarily triggering a generic loading dialog. This function is called when vault data is updating (e.g., after a sync), which caused the dialog to flash on the screen or remain due to race-conditions. The fix removes the call to `showLoadingDialog` from `handleVaultDataPending`. A more specific loading message, "Loading vault data...", has been added to the `handleVaultDataLoading` function to provide better user feedback when the initial data is being fetched. Additionally, a test case was updated to reflect that the loading dialog is no cleared during the pending state.
SaintPatrck
force-pushed
the
PM-26810/infinite-loading-after-otp
branch
from
b2e96ca to
0eafefc
Compare
david-livefront
approved these changes
Oct 22, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6068 +/- ##
==========================================
+ Coverage 84.23% 84.78% +0.54%
==========================================
Files 829 720 -109
Lines 57359 55050 -2309
Branches 7699 7654 -45
==========================================
- Hits 48319 46676 -1643
+ Misses 6345 5694 -651
+ Partials 2695 2680 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-26810
📔 Objective
This commit addresses a UI flicker issue where a loading dialog would briefly appear, or remain visible, when the vault data was being updated in the background during the item export flow.
The
handleVaultDataPendingfunction inReviewExportViewModelwas unnecessarily triggering a generic loading dialog. This function is called when vault data is updating (e.g., after a sync), which caused the dialog to flash on the screen or remain due to race-conditions.The fix removes the call to
showLoadingDialogfromhandleVaultDataPending. A more specific loading message, "Loading vault data...", has been added to thehandleVaultDataLoadingfunction to provide better user feedback when the initial data is being fetched. Additionally, a test case was updated to reflect that the loading dialog is not cleared during the pending state.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes