Skip to content

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 22, 2025

🎟️ Tracking

PM-27263

📔 Objective

This PR adds a little bit of type-safety to the Vault Timeout Policy by adding an enum to represent the action values.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront force-pushed the PM-27263-enumerate-vault-timeout-policy-actions branch from 893d2c9 to 1b85a73 Compare October 22, 2025 19:19
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

Logo
Checkmarx One – Scan Summary & Detailse22ae97a-c89a-4617-b7af-567c1e9085da

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.78%. Comparing base (92cfce1) to head (1b85a73).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...data/platform/repository/SettingsRepositoryImpl.kt 0.00% 3 Missing ⚠️
.../settings/accountsecurity/AccountSecurityScreen.kt 50.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6067      +/-   ##
==========================================
+ Coverage   84.23%   84.78%   +0.54%     
==========================================
  Files         829      720     -109     
  Lines       57359    55052    -2307     
  Branches     7699     7653      -46     
==========================================
- Hits        48319    46677    -1642     
+ Misses       6345     5694     -651     
+ Partials     2695     2681      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 5a540a3 Oct 22, 2025
9 checks passed
@david-livefront david-livefront deleted the PM-27263-enumerate-vault-timeout-policy-actions branch October 22, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants