Remove night-mode icon variants where possible #6066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
a team and
brian-livefront
as code owners
david-livefront
commented
Oct 22, 2025
| android:height="24dp" | ||
| android:viewportWidth="24" | ||
| android:viewportHeight="24"> | ||
| <group> |
Collaborator
Author
There was a problem hiding this comment.
This icon was never used.
david-livefront
commented
Oct 22, 2025
| // This is unspecified because selected icons are multi-tonal. | ||
| Color.Unspecified | ||
| } else { | ||
| BitwardenTheme.colorScheme.icon.primary |
Collaborator
Author
There was a problem hiding this comment.
This will also help with dynamic colors, since the unselected icons were not being tinted previously.
The selected icons multi-tonal and are tinted via the rememberVectorDrawable function.
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6066 +/- ##
==========================================
+ Coverage 84.23% 84.79% +0.55%
==========================================
Files 829 720 -109
Lines 57359 55051 -2308
Branches 7699 7654 -45
==========================================
- Hits 48319 46678 -1641
+ Misses 6345 5693 -652
+ Partials 2695 2680 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SaintPatrck
approved these changes
Oct 22, 2025
Collaborator
Author
|
Thanks @SaintPatrck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
This PR simplifies the navigation icons by removing the night-mode variants and relying on tinting where possible.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes