Skip to content

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 16, 2025

🎟️ Tracking

PM-27071

📔 Objective

This PR adds overflow options to the items in the Authenticator Search UI.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details4aa66152-d3c3-4882-86ab-01491d13404f

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 65.92593% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.80%. Comparing base (a70b217) to head (51ba910).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...i/authenticator/feature/search/ItemSearchScreen.kt 0.00% 28 Missing ⚠️
...nticator/feature/search/handlers/SearchHandlers.kt 0.00% 8 Missing ⚠️
...uthenticator/feature/search/ItemSearchViewModel.kt 94.68% 3 Missing and 2 partials ⚠️
.../authenticator/feature/search/ItemSearchContent.kt 0.00% 3 Missing ⚠️
.../feature/itemlisting/ItemListingGraphNavigation.kt 0.00% 1 Missing ⚠️
...thenticator/feature/search/ItemSearchNavigation.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6044      +/-   ##
==========================================
- Coverage   84.81%   84.80%   -0.02%     
==========================================
  Files         720      720              
  Lines       54632    54748     +116     
  Branches     7588     7603      +15     
==========================================
+ Hits        46337    46427      +90     
- Misses       5637     5664      +27     
+ Partials     2658     2657       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit 8f3f1fa Oct 17, 2025
9 checks passed
@david-livefront david-livefront deleted the PM-27071-search-overflow branch October 17, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants