-
Notifications
You must be signed in to change notification settings - Fork 927
[PM-26986] Hide select other account button if user has no other account #6041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-26986] Hide select other account button if user has no other account #6041
Conversation
|
New Issues (1)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6041 +/- ##
==========================================
- Coverage 84.80% 84.76% -0.05%
==========================================
Files 720 737 +17
Lines 54570 55284 +714
Branches 7578 7625 +47
==========================================
+ Hits 46278 46859 +581
- Misses 5639 5764 +125
- Partials 2653 2661 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| itemTypeCounts = ReviewExportState.ItemTypeCounts(), | ||
| ), | ||
| dialog = null, | ||
| hasOtherAccounts = (authRepository.userStateFlow.value?.accounts?.size ?: 0) > 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎨 We can use orEmpty() to clean this up a little.
| hasOtherAccounts = (authRepository.userStateFlow.value?.accounts?.size ?: 0) > 1, | |
| hasOtherAccounts = authRepository.userStateFlow.value?.accounts?.orEmpty().size > 1, |


🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26986
📔 Objective
Hide select other account if there are no other accounts
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes