Skip to content

Conversation

@AmyLGalles
Copy link
Contributor

🎟️ Tracking

In order to enable/disable the publish github workflow, the workflows need actions:write permissions to avoid this error: https://github.com/bitwarden/android/actions/runs/18560562779

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@AmyLGalles AmyLGalles requested a review from a team as a code owner October 16, 2025 16:42
@AmyLGalles AmyLGalles requested a review from pixman20 October 16, 2025 16:42
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.24%. Comparing base (3ace095) to head (1ed0f92).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6040   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files         861      861           
  Lines       57260    57260           
  Branches     7642     7642           
=======================================
  Hits        48237    48237           
  Misses       6342     6342           
  Partials     2681     2681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details66c78d52-119a-4283-9a70-45ca859bd48d

Great job! No new security vulnerabilities introduced in this pull request

@AmyLGalles AmyLGalles added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 53d0437 Oct 16, 2025
9 checks passed
@AmyLGalles AmyLGalles deleted the agalles/fix-workflow-name branch October 16, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants