-
Notifications
You must be signed in to change notification settings - Fork 927
[PM-26736] Prevent logout notification on KDF change #6038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6038 +/- ##
==========================================
+ Coverage 84.24% 84.81% +0.57%
==========================================
Files 836 720 -116
Lines 56967 54632 -2335
Branches 7623 7588 -35
==========================================
- Hits 47991 46337 -1654
+ Misses 6308 5637 -671
+ Partials 2668 2658 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /** | ||
| * Data object holding the feature flag key for the No Logout On KDF Change feature. | ||
| */ | ||
| data object NoLogoutOnKdfChange : FlagKey<Boolean>() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to the activePasswordManagerFlags above

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26736
📔 Objective
This pull request introduces a feature flag to control logout behavior when a push notification is received for a KDF (Key Derivation Function) change. If the new
NoLogoutOnKdfChangeflag is enabled, the app will avoid logging out the user when the logout reason is a KDF change.Feature: Avoid logout on KDF change
NoLogoutOnKdfChangetoFlagKey, including its display label and debug menu integration, allowing toggling the behavior from the UI.PushManagerImplto check the new flag and skip emitting logout events if the logout reason isKDF_CHANGEin push notifications.FeatureFlagManagertoPushManagerImpl.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes