Skip to content

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR consolidates the VaultVerificationCodeItem for the listing and search screens into a common composable and model.

📸 Screenshots

Before After
Screen_recording_20251015_112840.mp4
Screen_recording_20251015_112641.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Logo
Checkmarx One – Scan Summary & Detailsd9ed98a7-8111-495f-b50c-b5812efe2641

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.24%. Comparing base (f7cbcd2) to head (be469c3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...enticator/feature/itemlisting/ItemListingScreen.kt 33.33% 3 Missing and 3 partials ⚠️
.../authenticator/feature/search/ItemSearchContent.kt 0.00% 6 Missing ⚠️
...ure/util/SharedVerificationCodesStateExtensions.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6035      +/-   ##
==========================================
- Coverage   84.72%   84.24%   -0.49%     
==========================================
  Files         722      829     +107     
  Lines       54717    56864    +2147     
  Branches     7583     7616      +33     
==========================================
+ Hits        46358    47904    +1546     
- Misses       5706     6294     +588     
- Partials     2653     2666      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit 03df341 Oct 15, 2025
9 checks passed
@david-livefront david-livefront deleted the common-list-item branch October 15, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants