Expand supported credential types for import #6030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
a team,
brian-livefront and
david-livefront
as code owners
| ), | ||
| CredentialTypes.CREDENTIAL_TYPE_TOTP, | ||
| CredentialTypes.CREDENTIAL_TYPE_WIFI, | ||
| ).toList(), |
Collaborator
There was a problem hiding this comment.
Why change it to a set if we are just changing it back?
Contributor
Author
There was a problem hiding this comment.
Unintentional. Good catch. Thank you.
SaintPatrck
force-pushed
the
CXF-support-more-credential-types
branch
from
9501af1 to
deedd94
Compare
david-livefront
approved these changes
Oct 14, 2025
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
This commit expands the set of supported credential types for the "Import from another app" feature. The following credential types have been added to the import sources: - `CREDENTIAL_TYPE_API_KEY` - `CREDENTIAL_TYPE_CUSTOM_FIELDS` - `CREDENTIAL_TYPE_DRIVERS_LICENSE` - `CREDENTIAL_TYPE_IDENTITY_DOCUMENT` - `CREDENTIAL_TYPE_NOTE` - `CREDENTIAL_TYPE_PASSPORT` - `CREDENTIAL_TYPE_PERSON_NAME` - `CREDENTIAL_TYPE_WIFI` These changes are reflected in the `CredentialExchangeRegistryManager` and the `ImportItemsViewModel`, along with their corresponding test files to ensure the new types are correctly handled.
SaintPatrck
force-pushed
the
CXF-support-more-credential-types
branch
from
deedd94 to
bf9a1b0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6030 +/- ##
==========================================
- Coverage 84.73% 84.72% -0.01%
==========================================
Files 722 722
Lines 54686 54717 +31
Branches 7577 7583 +6
==========================================
+ Hits 46336 46358 +22
- Misses 5699 5706 +7
- Partials 2651 2653 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
This commit expands the set of supported credential types for the "Import from another app" feature.
The following credential types have been added to the import sources:
CREDENTIAL_TYPE_API_KEYCREDENTIAL_TYPE_CUSTOM_FIELDSCREDENTIAL_TYPE_DRIVERS_LICENSECREDENTIAL_TYPE_IDENTITY_DOCUMENTCREDENTIAL_TYPE_NOTECREDENTIAL_TYPE_PASSPORTCREDENTIAL_TYPE_PERSON_NAMECREDENTIAL_TYPE_WIFIThese changes are reflected in the
CredentialExchangeRegistryManagerand theImportItemsViewModel, along with their corresponding test files to ensure the new types are correctly handled.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes