-
Notifications
You must be signed in to change notification settings - Fork 927
[PM-23280] Use masterPasswordUnlock KDF settings on vault unlock #6026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6026 +/- ##
==========================================
- Coverage 84.73% 84.72% -0.01%
==========================================
Files 722 722
Lines 54686 54731 +45
Branches 7577 7590 +13
==========================================
+ Hits 46336 46373 +37
- Misses 5699 5703 +4
- Partials 2651 2655 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ?.masterPasswordUnlock | ||
| ?.kdf | ||
| ?.toKdf() | ||
| } ?: accountProfile.toSdkParams() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the elvis down a line
}
?: accountProfile.toSdkParams()| } | ||
|
|
||
| @Test | ||
| @Suppress("MaxLineLength") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this suppression

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-23280
📔 Objective
KDF Conversion Improvements
KdfJson.toKdf()inKdfExtensions.ktto convert aKdfJsonobject to a domainKdftype, applying default values for Argon2 parameters when not provided.Vault Unlock Logic Update
AuthRepositoryImplvault unlock flow to use themasterPasswordUnlockkdf parameters when they exist, or fallback to theaccount.profilekdf otherwise. This ensures the vault is unlocked with the correct KDF settings.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes