Add optional buttons to BitwardenEmptyContent #6022
Merged
+79
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
a team,
brian-livefront and
david-livefront
as code owners
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6022 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 722 722
Lines 54897 54919 +22
Branches 7581 7583 +2
=======================================
+ Hits 46440 46461 +21
Misses 5800 5800
- Partials 2657 2658 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * @param testTag The test tag for the button | ||
| * @param onClick The click listener for the button | ||
| */ | ||
| data class EmptyContentButton( |
Collaborator
There was a problem hiding this comment.
Can we make this more generic?
I could see this being used elsewhere.
| */ | ||
| data class EmptyContentButton( | ||
| val label: Text, | ||
| val testTag: String, |
Collaborator
There was a problem hiding this comment.
This could default null?
I can go either way.
This commit enhances the `BitwardenEmptyContent` composable to support optional primary and secondary action buttons. A new data class, `BitwardenButtonData`, is introduced to encapsulate the data required for rendering a button, including its label, click action, and test tag. The `BitwardenEmptyContent` composable has been updated to accept optional `BitwardenButtonData` for a primary (filled) and a secondary (outlined) button. When provided, these buttons are displayed below the main content text. The preview for this component has also been updated to demonstrate the new button functionality.
SaintPatrck
force-pushed
the
bitwarden-empty-content_optional-buttons
branch
from
a902621 to
ce5fa9f
Compare
david-livefront
approved these changes
Oct 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
This commit enhances the
BitwardenEmptyContentcomposable to support optional primary and secondary action buttons.A new data class,
BitwardenButtonData, is introduced to encapsulate the data required for rendering a button, including its label, click action, and test tag.The
BitwardenEmptyContentcomposable has been updated to accept optionalBitwardenButtonDatafor a primary (filled) and a secondary (outlined) button. When provided, these buttons are displayed below the main content text. The preview for this component has also been updated to demonstrate the new button functionality.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes