[PM-26395] Hide "my items" collection when item is assigned to other collection #6018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6018 +/- ##
==========================================
- Coverage 84.59% 84.55% -0.05%
==========================================
Files 722 736 +14
Lines 54897 55268 +371
Branches 7581 7591 +10
==========================================
+ Hits 46440 46730 +290
- Misses 5800 5877 +77
- Partials 2657 2661 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aj-rosado
requested review from
a team,
brian-livefront and
david-livefront
as code owners
| val selectableCollections: List<VaultCollection> | ||
| get() { | ||
| val collections = | ||
| organizations.first { it.id == selectedOrganizationId }.collections |
Collaborator
There was a problem hiding this comment.
Can we chain this:
val collections = organizations
.first { it.id == selectedOrganizationId }
.collections| selectedOrganization.collections.any { | ||
| it.id == collectionId && it.isDefaultUserCollection | ||
| } | ||
| } ?: false |
Collaborator
There was a problem hiding this comment.
Formatting here too:
cipherToMove
?.collectionIds
?.any { collectionId ->
selectedOrganization.collections.any {
it.id == collectionId && it.isDefaultUserCollection
}
}
?: false| it.id == collectionId && it.isDefaultUserCollection | ||
| } | ||
| } | ||
| ?: false |
Collaborator
There was a problem hiding this comment.
Thanks for updating that
david-livefront
approved these changes
Oct 14, 2025
aj-rosado
deleted the
PM-26395/hide-my-items-collection-on-collection-item
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26395
📔 Objective
When an item belongs to a collection, should not be displayed the "My items" collection
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes