[PM-26804] Clear password input after verification in VerifyPasswordViewModel
#6017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ViewModel` This commit addresses a security concern where the password input in the `VerifyPasswordViewModel` was not being cleared after successful verification. To resolve this, the password input field is now cleared from the view model's state upon successful password validation or vault unlock. The `input` field in `VerifyPasswordState` is also annotated with `@IgnoredOnParcel` to prevent it from being saved to the instance state, further enhancing security. Additionally, the `onCleared()` method is overridden to explicitly clear the password input, as a temporary workaround for a suspected OS-level memory leak. Corresponding unit tests have been updated to verify that the input is cleared after successful verification.
SaintPatrck
requested review from
a team,
brian-livefront and
david-livefront
as code owners
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6017 +/- ##
==========================================
- Coverage 84.59% 84.59% -0.01%
==========================================
Files 722 722
Lines 54891 54896 +5
Branches 7580 7580
==========================================
+ Hits 46436 46439 +3
- Misses 5798 5800 +2
Partials 2657 2657 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david-livefront
approved these changes
Oct 13, 2025
Contributor
Author
|
Thanks, @david-livefront! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-26804
📔 Objective
This commit addresses a security concern where the password input in the
VerifyPasswordViewModelwas not being cleared after successful verification.To resolve this, the password input field is now cleared from the view model's state upon successful password validation or vault unlock. The
inputfield inVerifyPasswordStateis also annotated with@IgnoredOnParcelto prevent it from being saved to the instance state, further enhancing security.Additionally, the
onCleared()method is overridden to explicitly clear the password input, as a temporary workaround for a suspected OS-level memory leak. Corresponding unit tests have been updated to verify that the input is cleared after successful verification.📸 Screenshots
Screen_recording_20251013_124313.mp4