Skip to content

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR updates a plural inside the app that do not actually have number based argument values to be regular strings.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront marked this pull request as ready for review October 13, 2025 15:29
@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsf4a6718c-4cab-4963-a28e-6c00d1ad3a35

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront david-livefront added this pull request to the merge queue Oct 13, 2025
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.45%. Comparing base (62f76a4) to head (92397dd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6016      +/-   ##
==========================================
- Coverage   84.59%   84.45%   -0.14%     
==========================================
  Files         722      744      +22     
  Lines       54891    55597     +706     
  Branches     7580     7589       +9     
==========================================
+ Hits        46436    46957     +521     
- Misses       5798     5982     +184     
- Partials     2657     2658       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit 4161020 Oct 13, 2025
9 checks passed
@david-livefront david-livefront deleted the fix-plurals branch October 13, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants