Skip to content

Add logging to UI module for Auth Tabs #6015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-livefront merged 1 commit into from
Oct 13, 2025
+4 −0
Merged

Add logging to UI module for Auth Tabs #6015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ dependencies {
implementation(libs.kotlinx.serialization)
implementation(libs.kotlinx.coroutines.core)
implementation(libs.kotlinx.collections.immutable)
implementation(libs.timber)
implementation(libs.zxing.zxing.core)

// For now we are restricted to running Compose tests for debug builds only
Expand Down
3 changes: 3 additions & 0 deletions ui/src/main/kotlin/com/bitwarden/ui/platform/manager/IntentManagerImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import com.bitwarden.ui.platform.manager.util.fileProviderAuthority
import com.bitwarden.ui.platform.model.FileData
import com.bitwarden.ui.platform.resource.BitwardenString
import com.bitwarden.ui.platform.util.getLocalFileData
import timber.log.Timber
import java.io.File
import java.time.Clock

Expand Down Expand Up @@ -80,9 +81,11 @@ internal class IntentManagerImpl(
) {
val providerPackageName = CustomTabsClient.getPackageName(activity, null).toString()
if (CustomTabsClient.isAuthTabSupported(activity, providerPackageName)) {
Timber.d("Launching uri with AuthTab for $providerPackageName")
AuthTabIntent.Builder().build().launch(launcher, uri, "bitwarden")
} else {
// Fall back to a Custom Tab.
Timber.d("Launching uri with CustomTabs fallback for $providerPackageName")
startCustomTabsActivity(uri = uri)
}
}
Expand Down
Loading