Correct environment variable names in build workflow #6008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6008 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 722 722
Lines 54882 54891 +9
Branches 7569 7579 +10
=======================================
+ Hits 46426 46436 +10
+ Misses 5805 5798 -7
- Partials 2651 2657 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Contributor
Author
SaintPatrck
force-pushed
the
fix-build-env-var-names
branch
from
3cc3e14 to
b5b3e9f
Compare
Contributor
Author
david-livefront
previously approved these changes
Oct 10, 2025
This commit fixes issues in the `build.yml` GitHub Actions workflow where environment variable names with hyphens were causing build failures. The hyphens have been replaced with underscores to ensure the variables are correctly referenced in the shell environment. Specifically, the following changes were made in `.github/workflows/build.yml`: * Updated environment variable names in the "Generate release Play Store bundle" step. * Corrected variable names for the "Generate beta Play Store bundle" step. * Fixed variable names in the "Generate release Play Store APK" step. * Updated environment variable names for the "Generate beta Play Store APK" step. * Corrected variable names in the "Generate F-Droid Beta Artifacts" step.
SaintPatrck
force-pushed
the
fix-build-env-var-names
branch
from
b5b3e9f to
24d8816
Compare
Contributor
Author
|
3rd run is a charm? 🤞 |
david-livefront
approved these changes
Oct 13, 2025
vvolkgang
approved these changes
Oct 13, 2025
Contributor
Author
|
Thanks @david-livefront and @vvolkgang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
This commit fixes issues in the
build.ymlGitHub Actions workflow where environment variable names with hyphens were causing build failures. The hyphens have been replaced with underscores to ensure the variables are correctly referenced in the shell environment.Specifically, the following changes were made in
.github/workflows/build.yml:⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes