Skip to content

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 10, 2025

🎟️ Tracking

N/A

📔 Objective

This PR ensures the statusbar content color is correct after turning the display on and off.

📸 Screenshots

Bewfore After
Screen_recording_20251010_114245.mp4
Screen_recording_20251010_114141.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc2df2a2f-de11-4921-9499-f770d81336ae

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.59%. Comparing base (5243ed2) to head (52ee03b).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...i/platform/base/util/StatusBarsAppearanceAffect.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6006   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         722      722           
  Lines       54882    54882           
  Branches     7569     7570    +1     
=======================================
  Hits        46426    46426           
  Misses       5805     5805           
  Partials     2651     2651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront added this pull request to the merge queue Oct 13, 2025
@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

Merged via the queue into main with commit 62f76a4 Oct 13, 2025
9 checks passed
@david-livefront david-livefront deleted the fix-statusbar-color branch October 13, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants