PM-26575: Add AuthTab support for WebAuthN, Duo, and SSO #6002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
a team and
brian-livefront
as code owners
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
david-livefront
force-pushed
the
PM-26575-auth-tabs
branch
from
7fe1262 to
8818d34
Compare
vvolkgang
reviewed
Oct 9, 2025
| AuthTabIntent.Builder().build().launch(launcher, uri, "bitwarden") | ||
| } else { | ||
| // Fall back to a Custom Tab. | ||
| startCustomTabsActivity(uri = uri) |
Member
There was a problem hiding this comment.
- Were you able to test browsers compatibility?
- When AuthTab is used, is there any visual indication of it?
- 💭 Perhaps we could log to FlightRecorder if AuthTab was used.
Collaborator
Author
There was a problem hiding this comment.
- In Chrome, Brave, and Edge AuthTab works well. In Firefox and Opera, it falls back to CustomTabs.
- They basically looks the same. The AuthTab does not allow users to open in Chrome though.
- Logs can be added but we'd need to add Timber to the
uimodule
| Custom Tab | Auth Tab |
|---|---|
 |
 |
vvolkgang
reviewed
Oct 9, 2025
david-livefront
force-pushed
the
PM-26575-auth-tabs
branch
3 times, most recently
from
cad5cb3 to
85e4005
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6002 +/- ##
=======================================
Coverage 84.59% 84.60%
=======================================
Files 722 722
Lines 54882 54894 +12
Branches 7569 7578 +9
=======================================
+ Hits 46426 46441 +15
+ Misses 5805 5796 -9
- Partials 2651 2657 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david-livefront
changed the title
SaintPatrck
reviewed
Oct 10, 2025
Contributor
There was a problem hiding this comment.
Can we either write a few tests for this, or omit it from coverage?
Collaborator
Author
There was a problem hiding this comment.
I added tests for the DuoUtils... I didn't realize it had none.
Tests for the AuthTabIntent.AuthResult have been omitted since mockking it is problematic.
david-livefront
force-pushed
the
PM-26575-auth-tabs
branch
from
85e4005 to
4ac247b
Compare
SaintPatrck
approved these changes
Oct 10, 2025
Collaborator
Author
|
Thanks @SaintPatrck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-26575
📔 Objective
This PR adds support for
AuthTabswhen logging in with Duo, WebAuthn, and SSO login flows.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes