Skip to content

Conversation

@SaintPatrck
Copy link
Contributor

🎟️ Tracking

PM-26718

📔 Objective

This commit moves the intent filter for handling Credential Exchange transfer requests from the debug manifest to the main AndroidManifest.xml.

The intent filter for the androidx.identitycredentials.action.IMPORT_CREDENTIALS action was previously only included in debug builds. This change moves it to the main manifest, making the credential import functionality available in all build variants, including release builds.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

This commit moves the intent filter for handling Credential Exchange transfer requests from the debug manifest to the main `AndroidManifest.xml`.

The intent filter for the `androidx.identitycredentials.action.IMPORT_CREDENTIALS` action was previously only included in debug builds. This change moves it to the main manifest, making the credential import functionality available in all build variants, including release builds.
@SaintPatrck SaintPatrck marked this pull request as ready for review October 8, 2025 19:44
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Logo
Checkmarx One – Scan Summary & Details313c8991-1c8a-474d-a01c-382796de4aa4

Great job! No new security vulnerabilities introduced in this pull request

@SaintPatrck SaintPatrck enabled auto-merge October 8, 2025 20:04
@SaintPatrck SaintPatrck added this pull request to the merge queue Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.53%. Comparing base (572d335) to head (7046492).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5995      +/-   ##
==========================================
- Coverage   84.57%   84.53%   -0.05%     
==========================================
  Files         720      734      +14     
  Lines       54678    55011     +333     
  Branches     7536     7538       +2     
==========================================
+ Hits        46242    46501     +259     
- Misses       5802     5877      +75     
+ Partials     2634     2633       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit 07b8115 Oct 8, 2025
9 checks passed
@SaintPatrck SaintPatrck deleted the cxf/app/relocate-intent-filter branch October 8, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants