PM-26689: Separate share logic from IntentManager #5987
Conversation
david-livefront
requested review from
a team and
brian-livefront
as code owners
| val autofillSaveItem = intent.getAutofillSaveItemOrNull() | ||
| val autofillSelectionData = intent.getAutofillSelectionDataOrNull() | ||
| val shareData = intentManager.getShareDataFromIntent(intent) | ||
| val shareData = shareManager.getShareDataOrNull(intent = intent) |
There was a problem hiding this comment.
This is the only spot in the app that used the IntentManager that was not a composable.
| /** | ||
| * Manages the retrieving data shared to this app. | ||
| */ | ||
| interface ShareManager { |
There was a problem hiding this comment.
I put this in the ui module but it could have gone directly into the app module. Any preference on where this end up living?
There was a problem hiding this comment.
I like it here in ui. Gives us more flexibility.
|
Great job! No new security vulnerabilities introduced in this pull request |
|
Thanks @SaintPatrck |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5987 +/- ##
==========================================
- Coverage 84.57% 84.56% -0.02%
==========================================
Files 717 719 +2
Lines 54544 54632 +88
Branches 7511 7531 +20
==========================================
+ Hits 46133 46197 +64
- Misses 5781 5802 +21
- Partials 2630 2633 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎟️ Tracking
PM-26689
📔 Objective
This PR separates the
ShareDatalogic from theIntentManager. This change allows theIntentManagerto be UI only and we can pass a fullActivityinto it, this will be required forAuthTabfunctionality.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes