Skip to content

Conversation

@SaintPatrck
Copy link
Contributor

🎟️ Tracking

PM-26330

📔 Objective

This commit fixes an issue where the owner data was not correctly set when the individual vault was disabled. The appendFolderAndOwnerData function in CipherViewExtensions.kt has been updated to correctly determine the default owner and collection when the individual vault is disabled.

Additionally, new tests have been added to CipherViewExtensionsTest.kt to cover this scenario.

📸 Screenshots

Coming soon!

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

This commit fixes an issue where the owner data was not correctly set when the individual vault was disabled. The `appendFolderAndOwnerData` function in `CipherViewExtensions.kt` has been updated to correctly determine the default owner and collection when the individual vault is disabled.

Additionally, new tests have been added to `CipherViewExtensionsTest.kt` to cover this scenario.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Logo
Checkmarx One – Scan Summary & Detailsab0f4a0d-d746-4d9d-a10b-ebc00e80cc23

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.38%. Comparing base (874edfa) to head (780343e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...vault/feature/addedit/util/CipherViewExtensions.kt 75.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5968      +/-   ##
==========================================
- Coverage   84.40%   84.38%   -0.03%     
==========================================
  Files         719      733      +14     
  Lines       54790    55134     +344     
  Branches     7530     7537       +7     
==========================================
+ Hits        46247    46523     +276     
- Misses       5904     5969      +65     
- Partials     2639     2642       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck SaintPatrck marked this pull request as ready for review October 2, 2025 14:08
@SaintPatrck SaintPatrck added this pull request to the merge queue Oct 2, 2025
Merged via the queue into main with commit 4e57f30 Oct 2, 2025
9 checks passed
@SaintPatrck SaintPatrck deleted the PM-26330/fix-default-owner-and-collection branch October 2, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants