PM-26358: Integrate the token auth logic with the SDK #5967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
a team and
brian-livefront
as code owners
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
david-livefront
force-pushed
the
PM-26358-sdk-auth-token
branch
from
d2427ec to
693cd10
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5967 +/- ##
=======================================
Coverage 84.40% 84.41%
=======================================
Files 719 720 +1
Lines 54790 54798 +8
Branches 7530 7531 +1
=======================================
+ Hits 46247 46256 +9
Misses 5904 5904
+ Partials 2639 2638 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david-livefront
force-pushed
the
PM-26358-sdk-auth-token
branch
from
693cd10 to
3f9b485
Compare
SaintPatrck
reviewed
Oct 2, 2025
| assertNull(authTokenManager.getAuthTokenDataOrNull()) | ||
| } | ||
| @Nested | ||
| inner class WithUserId { |
SaintPatrck
approved these changes
Oct 2, 2025
Collaborator
Author
|
Thanks @SaintPatrck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-26358
📔 Objective
This PR creates a bridge between the SDK and the network layer in order to allow the SDK to retrieve an updated auth token.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes