Skip to content

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Sep 29, 2025

🎟️ Tracking

PM-25642

📔 Objective

This PR updates the background sync and import logins sync to be a forced sync.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront force-pushed the PM-25642-improve-notification-sync branch from b664400 to ad25c5e Compare September 29, 2025 18:54
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025

Logo
Checkmarx One – Scan Summary & Details9756ab98-69ba-4b9f-b626-b69052bab4f2

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront david-livefront force-pushed the PM-25642-improve-notification-sync branch from ad25c5e to dcdedb1 Compare September 29, 2025 19:15
@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.39%. Comparing base (2363b0d) to head (dcdedb1).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...bitwarden/data/platform/manager/PushManagerImpl.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5958      +/-   ##
==========================================
+ Coverage   84.37%   84.39%   +0.02%     
==========================================
  Files         723      716       -7     
  Lines       54446    54434      -12     
  Branches     7481     7483       +2     
==========================================
+ Hits        45940    45941       +1     
+ Misses       5893     5878      -15     
- Partials     2613     2615       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit a02a84e Sep 29, 2025
9 checks passed
@david-livefront david-livefront deleted the PM-25642-improve-notification-sync branch September 29, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants