[PM-26315] Register/unregister for CXP export based on feature flag #5948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
SaintPatrck
force-pushed
the
cxf/app/export-registration
branch
4 times, most recently
from
da9db77 to
29c2740
Compare
SaintPatrck
changed the title
SaintPatrck
changed the title
SaintPatrck
requested review from
a team,
brian-livefront and
david-livefront
as code owners
SaintPatrck
force-pushed
the
cxf/app/export-registration
branch
3 times, most recently
from
7e06490 to
262e214
Compare
| credentialExchangeRegistry | ||
| .unregister() | ||
| .onSuccess { | ||
| settingsDiskSource.storeAppRegisteredForExport(isRegistered = false) |
Collaborator
There was a problem hiding this comment.
Won't this be cleared on logout anyways?
Contributor
Author
There was a problem hiding this comment.
No. It's not part of clearData() because it's a global setting. We only want to unregister when the last account logs out.
Collaborator
There was a problem hiding this comment.
Nevermind, this is a global setting, not tied to the user.
app/src/main/kotlin/com/x8bit/bitwarden/data/auth/manager/UserLogoutManagerImpl.kt
Outdated
Show resolved
Hide resolved
SaintPatrck
force-pushed
the
cxf/app/export-registration
branch
from
262e214 to
8da7529
Compare
| dispatcherManager: DispatcherManager, | ||
| ) : UserLogoutManager { | ||
| private val scope = CoroutineScope(dispatcherManager.unconfined) | ||
| private val unconfinedScope = CoroutineScope(dispatcherManager.unconfined) |
| val appName: String, | ||
| val credentialTypes: Set<String>, | ||
| @field:StringRes | ||
| val appName: Int, |
Collaborator
There was a problem hiding this comment.
Can we rename this to appNameRes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5948 +/- ##
==========================================
+ Coverage 84.59% 84.60% +0.01%
==========================================
Files 717 719 +2
Lines 54603 54660 +57
Branches 7519 7525 +6
==========================================
+ Hits 46191 46246 +55
- Misses 5781 5782 +1
- Partials 2631 2632 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SaintPatrck
force-pushed
the
cxf/app/export-registration
branch
2 times, most recently
from
e96c2f1 to
0b8fde7
Compare
This commit updates the Credential Exchange Protocol (CXP) export registration to be app-scoped rather than per-user. Key changes: - Unregister the app for CXP export on logout if it's the last remaining account. - Unregister for CXP export when the feature flag is disabled, and register when it's enabled. - Introduce `CredentialExchangeRegistryManager` to handle CXP registration and unregistration logic. - Update `isVaultRegisteredForExport` to `isAppRegisteredForExport` to reflect the app-wide scope.
SaintPatrck
force-pushed
the
cxf/app/export-registration
branch
from
0b8fde7 to
b377f29
Compare
david-livefront
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
This commit updates the Credential Exchange Protocol (CXP) export registration to be app-scoped rather than per-user.
Key changes:
CredentialExchangeRegistryManagerto handle CXP registration and unregistration logic.isVaultRegisteredForExporttoisAppRegisteredForExportto reflect the app-wide scope.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes