[PM-26094] Update Credential Manager library and remove stubs #5947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
a team,
brian-livefront and
david-livefront
as code owners
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
This commit updates the AndroidX Credential Manager library to `1.6.0-beta01` and the Credential Manager Provider Events library to `1.0.0-alpha03`. Additionally, this removes stub implementations for `androidx.credentials.providerevents` that are no longer needed with the updated library versions. The `CredentialTypes` constants used in `ImportItemsViewModel` and its corresponding test have also been updated to reflect changes in the newer library version.
SaintPatrck
force-pushed
the
cxf/deps/credentials-and-providerevents
branch
from
a435309 to
4cbe903
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5947 +/- ##
==========================================
+ Coverage 84.38% 84.40% +0.01%
==========================================
Files 725 718 -7
Lines 54498 54480 -18
Branches 7486 7486
==========================================
- Hits 45989 45982 -7
+ Misses 5893 5883 -10
+ Partials 2616 2615 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david-livefront
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-26094
📔 Objective
This commit updates the AndroidX Credential Manager library to
1.6.0-beta01and the Credential Manager Provider Events library to1.0.0-alpha03.Additionally, this removes stub implementations for
androidx.credentials.providereventsthat are no longer needed with the updated library versions.The
CredentialTypesconstants used inImportItemsViewModeland its corresponding test have also been updated to reflect changes in the newer library version.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes