-
Notifications
You must be signed in to change notification settings - Fork 927
[PM-23280] Save MasterPasswordUnlockData to local state #5944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…esponses, and save to profile.
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5944 +/- ##
==========================================
+ Coverage 84.36% 84.40% +0.03%
==========================================
Files 737 719 -18
Lines 54827 54809 -18
Branches 7487 7535 +48
==========================================
+ Hits 46257 46263 +6
+ Misses 5954 5905 -49
- Partials 2616 2641 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| policies: List<SyncResponseJson.Policy> = listOf(createMockPolicy(number = number)), | ||
| domains: SyncResponseJson.Domains = createMockDomains(number = number), | ||
| sends: List<SyncResponseJson.Send> = listOf(createMockSend(number = number)), | ||
| userDecryption: UserDecryptionJson? = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we give this a nonnull default
| val kdf: KdfJson, | ||
|
|
||
| @SerialName("MasterKeyWrappedUserKey") | ||
| val masterKeyWrappedUserKey: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you next PR has changes to this model. Can we get those in here and avoid the code churn
…ta inconsistency.

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-23280
📔 Objective
This pull request introduces support for the new
masterPasswordUnlockproperty within theUserDecryptionOptionsJsonmodel and ensures it is properly handled. The main changes focus on updating extension functions to correctly set this property, as well as updating test cases to reflect the new field.masterPasswordUnlockfield in thetoUserStateJson,toRemovedPasswordUserStateJson, andtoUserStateJsonWithPasswordextension functions to ensure this property is set appropriately during user state transformations.toUpdatedUserStateJsonfunction to copy or set themasterPasswordUnlockproperty based on the latest sync response, ensuring user state remains consistent with backend data.These changes ensure the codebase is ready to handle the new master password unlock data property.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes