Skip to content

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Sep 25, 2025

🎟️ Tracking

PM-26181

📔 Objective

This PR makes several minor adjustments to the Browser Autofill Integration components of the app.

  • All copy uses plurals based on how many troublesome browsers are installed
  • You must configure all browsers installed to be considered "done"
  • The VaultScreen dialog will not be displayed of the browser autofill badge is being displayed

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

.getShowImportLoginsSettingBadge(it),
showSetupBrowserAutofillCard = settingsDiskSource
.getShowUnlockSettingBadge(it),
.getShowBrowserAutofillSettingBadge(it),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bug that was missed.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details98ada5cf-5ca4-4e62-906f-54214af6f458

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.32%. Comparing base (d264586) to head (670bba9).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...bitwarden/ui/vault/feature/vault/VaultViewModel.kt 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5941      +/-   ##
==========================================
+ Coverage   84.31%   84.32%   +0.01%     
==========================================
  Files         721      721              
  Lines       54176    54190      +14     
  Branches     7449     7450       +1     
==========================================
+ Hits        45678    45697      +19     
+ Misses       5886     5881       -5     
  Partials     2612     2612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Sep 26, 2025
Merged via the queue into main with commit 617be1f Sep 26, 2025
9 checks passed
@david-livefront david-livefront deleted the PM-26181-browser-autofill-cleanup branch September 26, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants