Skip to content

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Sep 25, 2025

🎟️ Tracking

PM-26161

πŸ“” Objective

This PR adds badging support for the Browser Autofill configuration.

πŸ“Έ Screenshots

Screen_recording_20250925_102201.mp4

@david-livefront david-livefront force-pushed the PM-26161-browser-autofill-badging branch from dd4f5bb to 8d971ec Compare September 25, 2025 15:16
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Logo
Checkmarx One – Scan Summary & Details – 2a3f9a58-f4cf-4072-ae4f-a4287831e54e

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront david-livefront force-pushed the PM-26161-browser-autofill-badging branch from 8d971ec to 9e73086 Compare September 25, 2025 15:21
@david-livefront david-livefront force-pushed the PM-26161-browser-autofill-badging branch from 9e73086 to fde0587 Compare September 25, 2025 15:35
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 88.51351% with 17 lines in your changes missing coverage. Please review.
βœ… Project coverage is 84.31%. Comparing base (3edd5bd) to head (fde0587).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ure/accountsetup/SetupBrowserAutofillNavigation.kt 44.44% 10 Missing ⚠️
...th/feature/accountsetup/SetupAutoFillNavigation.kt 0.00% 5 Missing ⚠️
...ata/platform/manager/FirstTimeActionManagerImpl.kt 90.47% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5939   +/-   ##
=======================================
  Coverage   84.30%   84.31%           
=======================================
  Files         721      721           
  Lines       54077    54176   +99     
  Branches     7436     7449   +13     
=======================================
+ Hits        45591    45678   +87     
- Misses       5877     5886    +9     
- Partials     2609     2612    +3     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Parcelize
@Serializable(with = SetupBrowserAutofillRoute.Serializer::class)
data object SetupBrowserAutofillRoute : Parcelable {
sealed class SetupBrowserAutofillRoute : Parcelable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Sep 25, 2025
Merged via the queue into main with commit d264586 Sep 25, 2025
9 checks passed
@david-livefront david-livefront deleted the PM-26161-browser-autofill-badging branch September 25, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants