Skip to content

Conversation

@bw-ghapp
Copy link
Contributor

@bw-ghapp bw-ghapp bot commented Sep 25, 2025

Updates the SDK version from 1.0.0-3175-c9758478 to com.bitwarden:sdk-android 1.0.0-3194-9947387b

What's Changed

Raw changelog
- Expose ClientManagedTokens to mobile (#470)

@bw-ghapp bw-ghapp bot requested a review from brian-livefront as a code owner September 25, 2025 15:07
@bw-ghapp bw-ghapp bot added the automated-pr PR created by workflow or other automation label Sep 25, 2025
@bw-ghapp bw-ghapp bot requested a review from david-livefront as a code owner September 25, 2025 15:07
@bw-ghapp bw-ghapp bot added the t:ci Change Type - Updates to automated workflows label Sep 25, 2025
@bw-ghapp bw-ghapp bot requested a review from a team as a code owner September 25, 2025 15:07
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Logo
Checkmarx One – Scan Summary & Details44a8e193-ad12-4b20-be49-3c7d72c91f0f

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.40%. Comparing base (116bfd6) to head (d9fa708).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ator/data/platform/manager/SdkClientManagerImpl.kt 0.00% 6 Missing ⚠️
...rden/data/platform/manager/SdkClientManagerImpl.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5938      +/-   ##
==========================================
- Coverage   84.41%   84.40%   -0.02%     
==========================================
  Files         719      719              
  Lines       54782    54789       +7     
  Branches     7530     7530              
==========================================
  Hits        46244    46244              
- Misses       5897     5904       +7     
  Partials     2641     2641              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

/**
* The token provider to pass to the SDK.
*/
class Token : ClientManagedTokens {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense for AuthTokenManager to inherit ClientManagedTokens. That should make it easier to inject into SdkClientManagerImpl.

If we're only making a stubbed implementation for now, can we add a TODO comment and reference the associated ticket?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do that unless we want the network module to depend on the SDK, which is something I'd like to avoid.

I have some WIP locally to bridge the gap between the network layer and the SDK layer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaintPatrck @david-livefront Do I leave it like this? Or do I add the TODO so we can revisit this later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LRNcardozoWDF you can leave it as-is. @david-livefront already has a PR with his changes. 🥳

/**
* The token provider to pass to the SDK.
*/
class Token : ClientManagedTokens {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the actual implementation will always return null for Authenticator, we can define this as a private inner class of SdkClientManagerImpl if we can't pass null for tokenProvider.

@LRNcardozoWDF LRNcardozoWDF added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit 874edfa Oct 1, 2025
9 checks passed
@LRNcardozoWDF LRNcardozoWDF deleted the sdlc/sdk-update branch October 1, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-pr PR created by workflow or other automation t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants