-
Notifications
You must be signed in to change notification settings - Fork 927
Update SDK to 1.0.0-3194-9947387b #5938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
340f7d0 to
3c2306a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5938 +/- ##
==========================================
- Coverage 84.41% 84.40% -0.02%
==========================================
Files 719 719
Lines 54782 54789 +7
Branches 7530 7530
==========================================
Hits 46244 46244
- Misses 5897 5904 +7
Partials 2641 2641 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /** | ||
| * The token provider to pass to the SDK. | ||
| */ | ||
| class Token : ClientManagedTokens { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense for AuthTokenManager to inherit ClientManagedTokens. That should make it easier to inject into SdkClientManagerImpl.
If we're only making a stubbed implementation for now, can we add a TODO comment and reference the associated ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't do that unless we want the network module to depend on the SDK, which is something I'd like to avoid.
I have some WIP locally to bridge the gap between the network layer and the SDK layer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SaintPatrck @david-livefront Do I leave it like this? Or do I add the TODO so we can revisit this later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LRNcardozoWDF you can leave it as-is. @david-livefront already has a PR with his changes. 🥳
| /** | ||
| * The token provider to pass to the SDK. | ||
| */ | ||
| class Token : ClientManagedTokens { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the actual implementation will always return null for Authenticator, we can define this as a private inner class of SdkClientManagerImpl if we can't pass null for tokenProvider.
# Conflicts: # gradle/libs.versions.toml

Updates the SDK version from
1.0.0-3175-c9758478tocom.bitwarden:sdk-android 1.0.0-3194-9947387bWhat's Changed
Raw changelog