PM-26025: Add browser autofill screen for onboarding flow

[david-livefront]

🎟️ Tracking

PM-26025

📔 Objective

This PR adds a browser autofill screen for onboarding flow to help users migrate their browsers.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 49d4abb5-d84a-45fa-af87-1ae531a5a755

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

❌ Patch coverage is 92.69406% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.28%. Comparing base (b558d70) to head (dd4b1d3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...feature/accountsetup/SetupBrowserAutofillScreen.kt	92.70%	2 Missing and 5 partials ⚠️
...uth/feature/accountsetup/SetupAutoFillViewModel.kt	75.00%	2 Missing and 1 partial ⚠️
...en/ui/platform/feature/rootnav/RootNavViewModel.kt	66.66%	2 Missing and 1 partial ⚠️
...ure/accountsetup/SetupBrowserAutofillNavigation.kt	60.00%	2 Missing ⚠️
...ture/accountsetup/SetupBrowserAutofillViewModel.kt	98.24%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5931      +/-   ##
==========================================
+ Coverage   84.25%   84.28%   +0.02%     
==========================================
  Files         713      717       +4     
  Lines       53691    53869     +178     
  Branches     7401     7421      +20     
==========================================
+ Hits        45240    45406     +166     
- Misses       5856     5864       +8     
- Partials     2595     2599       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[SaintPatrck]

Can we use List<T>.toListItemCardStyle(index) here?

cardStyle = options.toListItemCardStyle(index),

[david-livefront]

We cannot because the bottom of the card is sometimes outside the list.

I was able to make a change to use toListItemCardStyle when there is no supportingText

[pamperer562580892423]

... I know, a PR is not a discussion board. 😉

So, in short as I saw the screenshot:

"Use Chrome autofill integration (Beta)" sounds like that integration would be "Beta"... I guess you mean that Chrome is Beta... And then I think this wording would be less ambiguous and better:

"Use Chrome (Beta) autofill integration"

(if you didn't mean Chrome Beta, then please ignore my ignorance)

[SaintPatrck]

Thanks, @pamperer562580892423

Great feedback, and I completely agree. @david-livefront, thoughts?

[david-livefront]

@pamperer562580892423 & @SaintPatrck I ran it by the design team and they agreed. It now reads Use Chrome Beta autofill integration

[david-livefront]

Thanks @SaintPatrck & @pamperer562580892423

[pamperer562580892423]

Thanks @david-livefront and @SaintPatrck! Small, but great change! 👍