[PM-26112] Handle Credential Exchange export requests #5928
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
SaintPatrck
force-pushed
the
cxf/app/export-special-circumstance
branch
from
9e7e191 to
96ea7b1
Compare
SaintPatrck
requested review from
a team,
brian-livefront and
david-livefront
as code owners
| <!-- Handle Credential Exchange transfer requests --> | ||
| <intent-filter | ||
| android:autoVerify="true" | ||
| tools:ignore="AppLinkUrlError"> |
There was a problem hiding this comment.
What's up with this error?
There was a problem hiding this comment.
I'm not really sure. This is the first time I've seen both of these. I have an pending request for more details about them. According to the integration guide this is how the intent-filter must be declared. It's possible this will change when the API is stable.
There was a problem hiding this comment.
I see, that is pretty odd
| <data | ||
| android:mimeType="application/octet-stream" | ||
| android:scheme="content" | ||
| tools:ignore="AppLinkUriRelativeFilterGroupError" /> |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5928 +/- ##
=======================================
Coverage 84.25% 84.25%
=======================================
Files 712 713 +1
Lines 53669 53690 +21
Branches 7395 7401 +6
=======================================
+ Hits 45217 45239 +22
+ Misses 5857 5856 -1
Partials 2595 2595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| fun NavGraphBuilder.selectAccountDestination( | ||
| onAccountSelected: (id: String) -> Unit, | ||
| ) { | ||
| composableWithPushTransitions<SelectAccountRoute> { |
There was a problem hiding this comment.
This believe this should use composableWithRootPushTransitions since it is the root of the graph.
This commit introduces the ability to handle Credential Exchange export requests. It includes the following changes: - Added `SpecialCircumstance.CredentialExchangeExport` to represent the app being launched for credential export. - Updated `RootNavViewModel` to navigate to a new `RootNavState.CredentialExchangeExport` when this special circumstance is detected. - Created a new `exportItemsGraph` for managing navigation related to exporting items, starting with a `SelectAccountScreen` (placeholder). - Modified `MainViewModel` to parse `ProviderImportCredentialsRequest` from the intent and set the appropriate special circumstance. - Added an intent filter in the debug `AndroidManifest.xml` to handle `androidx.identitycredentials.action.IMPORT_CREDENTIALS`.
SaintPatrck
force-pushed
the
cxf/app/export-special-circumstance
branch
from
96ea7b1 to
11cacf9
Compare
| fun SelectAccountScreen( | ||
| onAccountSelected: (id: String) -> Unit, | ||
| ) { | ||
| // TODO: [PM-26095] Implement select account screen. |
There was a problem hiding this comment.
Since there is no screen yet, should we block support for these deeplinks?
🎟️ Tracking
PM-26112
📔 Objective
This commit introduces the ability to handle Credential Exchange export requests.
When a
ProviderImportCredentialsRequestis received they will be navigated to the Export Items graph.It includes the following changes:
SpecialCircumstance.CredentialExchangeExportto represent the app being launched forcredential export.
RootNavViewModelto navigate to a newRootNavState.CredentialExchangeExportwhen thisspecial circumstance is detected.
exportItemsGraphfor managing navigation related to exporting items, starting witha
SelectAccountScreen(placeholder).MainViewModelto parseProviderImportCredentialsRequestfrom the intent and set theappropriate special circumstance.
AndroidManifest.xmlto handleandroidx.identitycredentials.action.IMPORT_CREDENTIALS.📸 Screenshots
Coming soon!
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes