Skip to content

Conversation

@SaintPatrck
Copy link
Contributor

🎟️ Tracking

N/A

📔 Objective

This commit moves the IntentHandler from androidx.credentials.providerevents.playservices to androidx.credentials.providerevents.

It also introduces credId to ProviderImportCredentialsRequest and renames BitwardenImportCredentialsRequest to ImportCredentialsRequestData, removing callingAppInfo from it.

The getProviderImportCredentialsRequest extension function on Intent now directly returns ProviderImportCredentialsRequest instead of mapping it to the Bitwarden-specific model.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

This commit moves the `IntentHandler` from `androidx.credentials.providerevents.playservices` to `androidx.credentials.providerevents`.

It also introduces `credId` to `ProviderImportCredentialsRequest` and renames `BitwardenImportCredentialsRequest` to `ImportCredentialsRequestData`, removing `callingAppInfo` from it.

The `getProviderImportCredentialsRequest` extension function on `Intent` now directly returns `ProviderImportCredentialsRequest` instead of mapping it to the Bitwarden-specific model.
@SaintPatrck SaintPatrck force-pushed the cxf/androidx/update-apis branch from 767ac33 to 79b6335 Compare September 23, 2025 18:27
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Logo
Checkmarx One – Scan Summary & Detailscbc65734-df0d-42bb-a044-0841e2323455

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.25%. Comparing base (cf5d208) to head (79b6335).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...vents/transfer/ProviderImportCredentialsRequest.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5926   +/-   ##
=======================================
  Coverage   84.24%   84.25%           
=======================================
  Files         713      712    -1     
  Lines       53671    53669    -2     
  Branches     7395     7395           
=======================================
  Hits        45217    45217           
+ Misses       5859     5857    -2     
  Partials     2595     2595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck SaintPatrck added this pull request to the merge queue Sep 23, 2025
Merged via the queue into main with commit e965134 Sep 23, 2025
9 checks passed
@SaintPatrck SaintPatrck deleted the cxf/androidx/update-apis branch September 23, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants