Skip to content

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Sep 22, 2025

🎟️ Tracking

N/A

📔 Objective

This PR updates the debug menu for both the Password Manager and Authenticator.

  • Support better UI when there are no feature flags.
  • Use Immutable Maps as state.
  • Use dummy flags for testing to avoid breaking tests when removing flags.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront marked this pull request as ready for review September 22, 2025 15:13
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

Logo
Checkmarx One – Scan Summary & Details142b6932-4363-4826-9276-98b34a99bbc0

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.27%. Comparing base (98530ed) to head (63fa0ee).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ature/debugmenu/components/FeatureFlagListItems.kt 0.00% 1 Missing and 1 partial ⚠️
...ature/debugmenu/components/FeatureFlagListItems.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5918   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files         712      712           
  Lines       53625    53626    +1     
  Branches     7387     7389    +2     
=======================================
+ Hits        45190    45192    +2     
- Misses       5832     5843   +11     
+ Partials     2603     2591   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

*/
data class DebugMenuState(
val featureFlags: Map<FlagKey<Any>, Any>,
val featureFlags: ImmutableMap<FlagKey<Any>, Any>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit fa5053b Sep 22, 2025
9 checks passed
@david-livefront david-livefront deleted the empty-feature-flags branch September 22, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants