-
Notifications
You must be signed in to change notification settings - Fork 927
Add empty state for debug menu without feature flags #5918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
631e70d to
ea0787f
Compare
ea0787f to
63fa0ee
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5918 +/- ##
=======================================
Coverage 84.27% 84.27%
=======================================
Files 712 712
Lines 53625 53626 +1
Branches 7387 7389 +2
=======================================
+ Hits 45190 45192 +2
- Misses 5832 5843 +11
+ Partials 2603 2591 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| */ | ||
| data class DebugMenuState( | ||
| val featureFlags: Map<FlagKey<Any>, Any>, | ||
| val featureFlags: ImmutableMap<FlagKey<Any>, Any>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Thanks @SaintPatrck |

🎟️ Tracking
N/A
📔 Objective
This PR updates the debug menu for both the Password Manager and Authenticator.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes