-
Notifications
You must be signed in to change notification settings - Fork 927
[PM-25825] Add ImportItems navigation #5915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f8277f2
Add ImportItems navigation
SaintPatrck 6e0835c
Testing 123
david-livefront 9243f78
Testing 456
david-livefront 77ee206
Refactor: Remove direct navigation to My Vault and Import Items from β¦
SaintPatrck de96c0e
Merge remote-tracking branch 'origin/main' into cxf/app/import-loginsβ¦
SaintPatrck 98ea780
Refactor import logins navigation
SaintPatrck eed0270
Rename ImportItemsGraphRoute to ImportItemsRoute
SaintPatrck c740b1d
Remove unused NavHostController import
SaintPatrck e2efd6f
Refactor ImportItemsViewModel to remove SnackbarRelayManager
SaintPatrck e148b1e
Update import items navigation based on feature flag
SaintPatrck 72709d6
Refactor: Remove blank line in VaultSettingsScreenTest
SaintPatrck 344619f
Remove VAULT_SYNC_FAILED from SnackbarRelay
SaintPatrck 7fda17d
Fix failing test
SaintPatrck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
.../x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarNavigation.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,5 +21,4 @@ enum class SnackbarRelay { | |
| LOGINS_IMPORTED, | ||
| SEND_DELETED, | ||
| SEND_UPDATED, | ||
| VAULT_SYNC_FAILED, | ||
| } | ||
40 changes: 40 additions & 0 deletions
40
...src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/importitems/ImportItemsNavigation.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| @file:OmitFromCoverage | ||
|
|
||
| package com.x8bit.bitwarden.ui.vault.feature.importitems | ||
|
|
||
| import androidx.navigation.NavController | ||
| import androidx.navigation.NavGraphBuilder | ||
| import androidx.navigation.NavOptions | ||
| import com.bitwarden.annotation.OmitFromCoverage | ||
| import com.bitwarden.ui.platform.base.util.composableWithPushTransitions | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| /** | ||
| * The type-safe route for the import items screen. | ||
| */ | ||
| @Serializable | ||
| data object ImportItemsRoute | ||
|
|
||
| /** | ||
| * Helper function to navigate to the import items screen. | ||
| */ | ||
| fun NavController.navigateToImportItemsScreen( | ||
| navOptions: NavOptions? = null, | ||
| ) { | ||
| navigate(route = ImportItemsRoute, navOptions = navOptions) | ||
| } | ||
|
|
||
| /** | ||
| * Add the import items screen to the nav graph. | ||
| */ | ||
| fun NavGraphBuilder.importItemsDestination( | ||
| onNavigateBack: () -> Unit, | ||
| onNavigateToImportLogins: () -> Unit, | ||
| ) { | ||
| composableWithPushTransitions<ImportItemsRoute> { | ||
| ImportItemsScreen( | ||
| onNavigateBack = onNavigateBack, | ||
| onNavigateToImportFromComputer = onNavigateToImportLogins, | ||
| ) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π