Skip to content

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR extracts the remaining Sync logic into the VaultSyncManager.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025

Logo
Checkmarx One – Scan Summary & Details4aca6642-32ae-48ed-a21c-05a26a16b90d

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront david-livefront added the hold do not merge yet label Sep 23, 2025
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 92.93286% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.39%. Comparing base (fd555e9) to head (ac8057b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...twarden/data/vault/manager/VaultSyncManagerImpl.kt 91.96% 6 Missing and 14 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5912      +/-   ##
==========================================
+ Coverage   84.36%   84.39%   +0.02%     
==========================================
  Files         737      723      -14     
  Lines       54827    54470     -357     
  Branches     7487     7484       -3     
==========================================
- Hits        46257    45969     -288     
+ Misses       5954     5888      -66     
+ Partials     2616     2613       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront marked this pull request as ready for review September 26, 2025 19:01
@david-livefront david-livefront removed the hold do not merge yet label Sep 26, 2025
@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit f0946e0 Sep 29, 2025
9 checks passed
@david-livefront david-livefront deleted the extract-more-sync-logic branch September 29, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants