-
Notifications
You must be signed in to change notification settings - Fork 927
BRE-1158 Dockerfiles shared ownership #5902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5902 +/- ##
=======================================
Coverage 84.37% 84.37%
=======================================
Files 725 725
Lines 54473 54473
Branches 7480 7480
=======================================
Hits 45964 45964
Misses 5893 5893
Partials 2616 2616 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job! No new security vulnerabilities introduced in this pull request |
.github/CODEOWNERS
Outdated
| # Default shared ownership of Dockerfile | ||
| **/Dockerfile @bitwarden/team-appsec @bitwarden/dept-bre | ||
| **/*.dockerignore @bitwarden/team-appsec @bitwarden/dept-bre | ||
| **/entrypoint.sh @bitwarden/team-appsec @bitwarden/dept-bre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use Dockerfiles. Is this being added just to future-proof the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fntyler friendly nudge. This seems unnecessary considering we don't use Dockerfiles. Is this purely a preventative measure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SaintPatrck thank you for the nudge. I am using a script to include these changes across all repositories. Though it isn't applicable here, this would be used in case a Docker-related file was introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. Thanks for confirming.

🎟️ Tracking
BRE-1158
📔 Objective
Include AppSec team and BRE dept for repository-level ownership of Dockerfile, and Dockerfile related, files.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes