Skip to content

Conversation

@fntyler
Copy link
Contributor

@fntyler fntyler commented Sep 17, 2025

🎟️ Tracking

BRE-1158

📔 Objective

Include AppSec team and BRE dept for repository-level ownership of Dockerfile, and Dockerfile related, files.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.37%. Comparing base (617be1f) to head (7bfe837).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5902   +/-   ##
=======================================
  Coverage   84.37%   84.37%           
=======================================
  Files         725      725           
  Lines       54473    54473           
  Branches     7480     7480           
=======================================
  Hits        45964    45964           
  Misses       5893     5893           
  Partials     2616     2616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Logo
Checkmarx One – Scan Summary & Detailscfdc7626-9871-4710-89dd-ace09ca6734b

Great job! No new security vulnerabilities introduced in this pull request

@fntyler fntyler marked this pull request as ready for review September 17, 2025 20:12
@fntyler fntyler requested a review from a team as a code owner September 17, 2025 20:12
Comment on lines 52 to 55
# Default shared ownership of Dockerfile
**/Dockerfile @bitwarden/team-appsec @bitwarden/dept-bre
**/*.dockerignore @bitwarden/team-appsec @bitwarden/dept-bre
**/entrypoint.sh @bitwarden/team-appsec @bitwarden/dept-bre
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use Dockerfiles. Is this being added just to future-proof the repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fntyler friendly nudge. This seems unnecessary considering we don't use Dockerfiles. Is this purely a preventative measure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaintPatrck thank you for the nudge. I am using a script to include these changes across all repositories. Though it isn't applicable here, this would be used in case a Docker-related file was introduced.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. Thanks for confirming.

@SaintPatrck SaintPatrck added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit df63bb4 Sep 29, 2025
9 checks passed
@SaintPatrck SaintPatrck deleted the bre/bre-1158/co-dockerfiles branch September 29, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants