Skip to content

Conversation

@AmyLGalles
Copy link
Contributor

@AmyLGalles AmyLGalles commented Sep 16, 2025

This updated was tested during the 10/2/25 clients release

Added dry-run option to publish-store.yml

publish-store.yml will enable github release workflows once release to the ios app store is complete.

publish-github-release.yml is now publish-github-release-bwa.yml and publish-github-release-bwa.yml so that they can be enabled or disabled based on which project was released. They now run hourly when enabled.

The workflow gh-actions/_publish-mobile-github-release.yml disables the workflow that ran it once it completes successfully.

🎟️ Tracking

Original Ticket
Follow up for testing

📔 Objective

Right now the check runs at 3am M-F, so if it fails on a Friday it doesn’t run again until Monday, which causes CI jobs to fail. This happens since they use the existing GH release to determine the version and cannot upload using the same version that’s currently rolling out.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@AmyLGalles AmyLGalles requested a review from pixman20 September 16, 2025 21:43
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025

Logo
Checkmarx One – Scan Summary & Details0e0bd0cd-e04d-401f-8148-fb3c6b6a543d

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.59%. Comparing base (433b3b6) to head (c27a4c8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5895   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         722      722           
  Lines       54919    54919           
  Branches     7583     7583           
=======================================
  Hits        46460    46460           
  Misses       5800     5800           
  Partials     2659     2659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AmyLGalles AmyLGalles marked this pull request as ready for review October 3, 2025 18:03
@AmyLGalles AmyLGalles requested a review from a team as a code owner October 3, 2025 18:03
@AmyLGalles AmyLGalles changed the title [BRE-1118] temporarily enable hourly checks for github release [BRE-1194] temporarily enable hourly checks for github release Oct 3, 2025
AmyLGalles and others added 2 commits October 3, 2025 14:18
Co-authored-by: Andy Pixley <3723676+pixman20@users.noreply.github.com>
@AmyLGalles AmyLGalles requested a review from pixman20 October 3, 2025 21:23
Co-authored-by: Andy Pixley <3723676+pixman20@users.noreply.github.com>
@AmyLGalles AmyLGalles requested a review from pixman20 October 8, 2025 18:32
aj-bw
aj-bw previously approved these changes Oct 10, 2025
pixman20
pixman20 previously approved these changes Oct 13, 2025
@AmyLGalles AmyLGalles dismissed stale reviews from pixman20 and aj-bw via 3a0a0d6 October 14, 2025 18:07
@AmyLGalles AmyLGalles added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit 9e86000 Oct 14, 2025
9 checks passed
@AmyLGalles AmyLGalles deleted the agalles/BRE-1118 branch October 14, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants